]> dgit.raspbian.org Git - gnome-shell.git/commit
shellInfo: Don't destroy source on undo
authorFlorian Müllner <fmuellner@gnome.org>
Thu, 8 Jul 2021 17:23:38 +0000 (19:23 +0200)
committerMarge Bot <marge-bot@gnome.org>
Tue, 13 Jul 2021 12:38:51 +0000 (12:38 +0000)
commit6995c2fa9f1a0b6cf673d233a0bd9f615c3093ef
treebb5a2e0bb694e7682c8973a5b579503263579bef
parent1f4eea12a53e2ee126e1eca58dfb6e875ae3b72e
shellInfo: Don't destroy source on undo

Destroying the source from an action callback will result in the
notification being destroyed twice:

 - source.destroy() destroys all its notifications

 - a notification destroys itself after an action
   was activated

This results in unwanted log spam when attempting to dispose the
notification for a second time.

There is actually no good reason for destroying the source explicitly,
as sources already self-destruct with their last notification.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4457

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1908>
js/ui/overview.js